Skip to content

Fix non-integer conditional witness binding - #31

Merged
Daniele-Cangi merged 3 commits into
mainfrom
codex/integer-witness-binding
Oct 8, 2026
Merged

Daniele-Cangi merged 3 commits into
mainfrom
codex/integer-witness-binding

Conversation

@Daniele-Cangi

@Daniele-Cangi Daniele-Cangi commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Separate invalid_integer from invalid_positive_integer; generic non-integer probes use not-an-integer instead of zero.
  • Concrete integer inputs override misleading test names/planned branch mappings, while unknown inputs retain conservative fallback.
  • Preserve non-integer coverage of stricter positive-integer branches without promoting previously unrecognized predicate forms.
  • Address the confirmed P2 review finding using one declaration-scoped CLI role resolver shared by literal-test analysis and validator probes. Support both role-before-argv and argv-before-role declarations, without crossing other argv bindings, conjunctions, or clause boundaries.
  • Refuse ambiguous, out-of-range or colliding filename/numeric probe bindings. Quoted output examples do not declare input roles.

Verification

  • Original checkpoint: 798 CI tests and Docker extended benchmark 30/30 passed on 293d274.
  • Review follow-up regression-first run: 10 failed, 1 passed before the fix.
  • Follow-up conditional/coder tests: 82 passed; four additional resolver guard tests passed.
  • Conditional/Validator/requirement-fidelity/preservation integration run: 175 passed on follow-up head 832c89a.
  • Minimal Forge smoke passed, no optional runtimes loaded.
  • Known V11-001 partial conditional-layer diagnostic remains unchanged: signed-integer reference accepted, seven direct reference controls passed. The zero-rejecting mutant also passes the non-integer-only probe; valid-zero semantics need distinct behavioral evidence. No end-to-end or blind preservation claim is made.
  • Final head 832c89a: 813 CI tests passed; Docker extended benchmark 30/30, status accuracy and Verified@1 1.000, false-verified rate 0.000, threshold gate passed, zero model tokens/cost. Both push and PR CI runs, minimal runtime and CodeQL are green. The reproduced P2 review thread is resolved; no fresh automated review/approval is claimed.

Scope

No model calls, retries, case-specific production rules, new domains, rollback changes, baseline rescoring, README or frozen-evidence changes. No automatic merge or review/fix loop. Only a reproduced review issue was addressed.

@Daniele-Cangi

Copy link
Copy Markdown
Owner Author

@codex review

Please review the narrow non-integer versus positive-integer witness correction, literal test-input applicability, coverage subset compatibility, and fail-closed unavailable probes. Check for regressions without requesting case-specific rules or expanding recognized predicate forms. Known V11 diagnostics are partial conditional-layer evidence, not blind or end-to-end preservation claims.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T22:19:08.219489Z 293d274 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 293d274fd1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread core/forge/conditional_test_evidence.py Resolved
@Daniele-Cangi
Daniele-Cangi merged commit 3804f1d into main Oct 8, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant