Kb privacy rng - #88
Merged
Merged
Conversation
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
filipleple
requested changes
Jul 22, 2026
filipleple
left a comment
filipleple
left a comment
Member
There was a problem hiding this comment.
LGTM and seems to work nice, seems like there's one wrapping issue though
Co-authored-by: Filip Lewiński <filip.lewinski@3mdeb.com> Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
filipleple
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on NV41MZ TGL with Dasharo v1.6.0-rc4.
A video shows the feature in action, typetimer.netlify.app was used to measure the time between consecutive key presses. During the test the
Fn+Scombination was pressed a couple times to enable/disable keyboard privacy feature.Screencast From 2026-07-17 14-56-19.webm
I've also tested whether it affects the typing experience. I've performed two typing speed tests, one with the feature enabled, one with it being disabled achieving similar results. It was annoying at first, but it's not that difficult to get used to it.
Normal:
Keyboard privacy:
The slight random delay is definitely noticeable. It will definitely be annoying for someone who's not aware of it, but it does not affect typing that much unless someone needs to follow the characters appearing on screen during typing.
I think the maximum delay could be decreased, but it's hard to tell what would be the limit that would make the feature still provide privacy benefits. I'd guess keeping it at about 30ms could still be perfectly fine, but that's just a git feeling.