Update LocationIQReverse - #359
Open
g-mc wants to merge 3 commits into
Open
Conversation
* Import `Location` to properly split given latitude/longitude * Modify `_URL` to use `reverse` endpoint instead * Modify `_build_params` for `reverse` endpoint * Modify `_adapt_results` to put single JSON response in a list * Modify coordinates in `LocationIQReverse` example (from unittest)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to use LocationIQ's reverse geocoding, I came across the same issue (partly) as mentioned in #353 . This PR updates
LocationIQReverseto use their'reverse.php'endpoint and also updates the test accordingly. I didn't look at the OpenStreetMap yet so it seems like this PR might only be fixing 50% of #353Main changes:
Locationto properly split given latitude/longitude_URLto usereverseendpoint instead_build_paramsforreverseendpoint_adapt_resultsto put single JSON response in a listLocationIQReverseexample (from unittest)As I am new to this library, I'm not 100% sure if my modification of
_adapt_resultsis the best way to achieve the correct response but it was raising errors without returning a single item list ofjson_response. If there is a better way, let me know and I will try to update this PR.