Skip to content

Quality: Mutable internal state is exposed directly by logger #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tuanaiseo wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Quality: Mutable internal state is exposed directly by logger #1769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/pyright-internal/src/analyzer/importLogger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ export class ImportLogger {
}

getLogs() {
return this._logs;
return [...this._logs];

@DetachHead DetachHead Apr 7, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should avoid copying the array at runtime which could potentially impact performance by just widening the return type to readonly string[] instead. this also prevents the returned list from being mutated, which shouldn't be allowed either

    getLogs(): readonly string[] {
        return this._logs;
    }
}

}
}
Loading