Repository navigation
Unpin time dependency and bump MSRV to 1.84 - #10
Merged
Merged
Conversation
Rely on Cargo's v3 resolver to respect the root crate's MSRV when resolving the time dependency instead of pinning it exactly.
MSRV-aware dependency resolution (resolver.incompatible-rust-versions = "fallback") requires Rust 1.84, so users can't opt into it while our MSRV is lower.
Diggsey
changed the title
Without this, `cargo test` on the MSRV job resolves dependencies to their newest versions (e.g. time 0.3.53, which requires Rust 1.88), causing the build to fail. Setting CARGO_RESOLVER_INCOMPATIBLE_RUST_VERSIONS=fallback makes Cargo prefer versions compatible with our declared rust-version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timedependency (from=0.3.41to0.3.41).Why unpin
time?time0.3.42+ requires rustc 1.81.0, which is why it was previously pinned to an exact version. Cargo's v3 resolver already takes the root crate'srust-version(MSRV) into account when resolving dependencies, so a too-newtimewon't be selected for users on an older toolchain — the exact pin is unnecessary.Why bump MSRV to 1.84?
MSRV-aware dependency resolution is only fully usable once users can opt into it via
resolver.incompatible-rust-versions = "fallback", and that config key requires Rust 1.84. With an MSRV below 1.84, users can't enable the fallback behavior that makes unpinningtimesafe for them. Raising our MSRV to 1.84 ensures the resolver mechanism this PR relies on is actually available to consumers of the crate.Note: this raises the effective MSRV for all users of the crate.