Conversation
Registering a plugin before EWC.Init failed: the plugin path needs RESOURCES to mount against and LOGMODES to log through, and neither exists until Init runs setDefaults. ensurePlugins now calls setDefaults itself, which is safe because it only fills in names that are undefined. An application is also free to assign EWC.RESOURCES wholesale - demo/Run does exactly that - which silently dropped mounts made by a plugin that had registered earlier. Init re-applies every registered plugin's resources once RESOURCES has settled. Also stop ⎕SE.Link.Break's "Not linked" result printing to the session: it is a returned value, not an error, so it needs discarding.
Contributor
Author
|
I believe it works - it certainly achieves the first boundary of allowing Kendo charts to be introduced in to EWC from application code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first draft of a plugin mechanism.