Skip to content

Don't fail hooks if CUDA-Samples version is not recognised #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laraPPr merged 4 commits into from
Jul 9, 2026
Merged

Don't fail hooks if CUDA-Samples version is not recognised #262

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db46d00
Don't fail hooks if CUDA-Sample version is not recognised
ocaisa Jul 8, 2026
3d3720c
Merge branch 'main' into cuda_samples
ocaisa Jul 8, 2026
625e574
Update eb_hooks.py
ocaisa Jul 8, 2026
a05676d
Update eb_hooks.py
ocaisa Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions eb_hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1141,21 +1141,23 @@ def pre_configure_hook_BLIS(self, *args, **kwargs):

def pre_configure_hook_CUDA_Samples_test_remove(self, *args, **kwargs):
"""skip immaTensorCoreGemm in CUDA-Samples for compute capability 7.0."""
if self.name == 'CUDA-Samples' and self.version in ['12.1']:
# Get compute capability from build option
cuda_caps = build_option('cuda_compute_capabilities')
# Check if compute capability 7.0 is in the list
if cuda_caps and '7.0' in cuda_caps:
print_msg("Applying hook for CUDA-Samples %s with compute capability 7.0", self.version)
# local_filters is set by the easyblock, remove path to the Makefile instead
makefile_path = os.path.join(self.start_dir, 'Samples/3_CUDA_Features/immaTensorCoreGemm/Makefile')
if os.path.exists(makefile_path):
remove_file(makefile_path)
print_msg("Removed Makefile at %s to skip immaTensorCoreGemm build", makefile_path)
else:
print_msg("Makefile not found at %s", makefile_path)
else:
raise EasyBuildError("CUDA-Samples-specific hook triggered for non-CUDA-Samples easyconfig?!")
if self.name == 'CUDA-Samples':
if self.version in ['12.1']:
# Get compute capability from build option
cuda_caps = build_option('cuda_compute_capabilities')
# Check if compute capability 7.0 is in the list
if cuda_caps and '7.0' in cuda_caps:
print_msg("Applying hook for CUDA-Samples %s with compute capability 7.0", self.version)
# local_filters is set by the easyblock, remove path to the Makefile instead
makefile_path = os.path.join(self.start_dir, 'Samples/3_CUDA_Features/immaTensorCoreGemm/Makefile')
if os.path.exists(makefile_path):
remove_file(makefile_path)
print_msg("Removed Makefile at %s to skip immaTensorCoreGemm build", makefile_path)
else:
print_msg("Makefile not found at %s", makefile_path)
else:
print_warning(f"CUDA-Samples hook triggered but version {self.version} does not have a code path.")
Comment thread
ocaisa marked this conversation as resolved.
Outdated



def pre_configure_hook_grass(self, *args, **kwargs):
Expand Down
Loading