Prepare ESMG-configs for changes in defaults - #17
Open
Hallberg-NOAA wants to merge 1 commit into
Open
Conversation
Explicitly set the values of certain parameters in some of the ESMG-configs test cases that would be impacted by planned changes in their default values. A total of 4 MOM_input files were modified. The parameters that are being explicitly set include ADJUST_BT_CONT (4 instances), BT_NONLIN_STRESS (4), CHANNEL_FLOW_OBC_TRANSPORT_BUG (1), INTEGRAL_BT_CONTINUITY (4), KELVIN_SET_OBC_INDEXING_BUGS(1), LINEARIZED_BT_CORIOLIS (41) and OBC_PROJECTION_BUG (2). All answers are bitwise identical, both with the existing dev/gfdl code and with the code with the proposed changes in default values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly set the values of certain parameters in some of the ESMG-configs test cases that would be impacted by planned changes in their default values. A total of 4 MOM_input files were modified. The parameters that are being explicitly set include
ADJUST_BT_CONT(4 instances),BT_NONLIN_STRESS(4),CHANNEL_FLOW_OBC_TRANSPORT_BUG(1),INTEGRAL_BT_CONTINUITY(4),KELVIN_SET_OBC_INDEXING_BUGS(1),LINEARIZED_BT_CORIOLIS(41) andOBC_PROJECTION_BUG(2). All answers are bitwise identical, both with the existing dev/gfdl code and with the code with the proposed changes in default values.