Bump package versions, make ci pipeline more forkable and add arm/v7 platform#151
Open
lukas-mertens wants to merge 7 commits into
Open
Bump package versions, make ci pipeline more forkable and add arm/v7 platform#151lukas-mertens wants to merge 7 commits into
lukas-mertens wants to merge 7 commits into
Conversation
Signed-off-by: Lukas Mertens <git@lukas-mertens.de>
…ushed at the same time Signed-off-by: Lukas Mertens <git@lukas-mertens.de>
…able versions Signed-off-by: Lukas Mertens <git@lukas-mertens.de>
18.20.4+dfsg-1~deb12u1 was replaced by a security update and is no longer available in the Debian 12 repos. Signed-off-by: Lukas Mertens <git@lukas-mertens.de>
Before everything was hardcoded to ghcr.io/everest/everest-ci as the base registry, causing builds to fail on forks where run-env-base and build-env-base are pushed to the fork's own registry. BASE_IMAGE_REGISTRY is now passed as a build arg derived from github.repository_owner, so forks automatically pull their own freshly-built base images. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Lukas Mertens <git@lukas-mertens.de>
…ilable versions Signed-off-by: Lukas Mertens <git@lukas-mertens.de>
The previously pinned versions of docker-ce, docker-ce-cli, containerd.io, docker-buildx-plugin and docker-compose-plugin were removed from download.docker.com and are no longer available. Signed-off-by: Lukas Mertens <git@lukas-mertens.de>
Up to standards ✅🟢 Issues
|
andistorm
requested changes
Jun 15, 2026
|
|
||
| concurrency: | ||
| group: deploy-docker-images-${{ github.ref }} | ||
| cancel-in-progress: false |
Member
There was a problem hiding this comment.
Suggested change
| cancel-in-progress: false | |
| queue: max |
Not sure if this is equivalent, but github's documentation doesn't explain explicitly the scenario of setting cancel-in-progress: false
| build_args: | | ||
| BASE_IMAGE_TAG=${{ needs.run-env-base.outputs.one_image_tag_short }} | ||
|
|
||
| BASE_IMAGE_REGISTRY=${{ needs.env-setup.outputs.docker_registry }}/${{ github.repository_owner }}/${{ needs.env-setup.outputs.repository_name }} |
Member
There was a problem hiding this comment.
Would be good to move this "calculation" to env-setup and add a output there so we don't need to maintain this at multiple locations
| ENV LIBSQLITE3_DEV_VERSION=3.40.1-2+deb12u2 | ||
| # renovate: datasource=repology depName=debian_12/openssl versioning=loose | ||
| ENV LIBSSL_DEV_VERSION=3.0.18-1~deb12u2 | ||
| ENV LIBSSL_DEV_VERSION=3.0.19-1~deb12u2 |
Member
There was a problem hiding this comment.
Would be good to have a separate PR at least for those version bumps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My initial goal was to add armv7 support. While building that, I noticed that it would be nice to be able to execute the CI pipeline on forks as well to test everything everything easily. Also I think adding a concurrency group makes sense to prevent multiple pushes happening to the same target at the same time. And for getting everything to build again, I also had to update some packages.
Everything is split into individual commits, so it might make sense to review them individually and merge without squashing.
I can also split this out into multiple pull requests if it makes sense, but as all changes were necessary to get a successful build again I decided against it for now.