Skip to content

fix(ssl): include ACME error message in operator-facing warnings #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrrobot47 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(ssl): include ACME error message in operator-facing warnings #486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/helper/Site_Letsencrypt.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ public function check( Array $domains, $wildcard = false, $preferred_challenge =
$authorizationChallengeToCleanup[] = $authorizationChallenge;
} catch ( \Exception $e ) {
\EE::debug( $e->getMessage() );
\EE::warning( 'Challenge Authorization failed. Check logs and check if your domain is pointed correctly to this server.' );
\EE::warning( 'Challenge Authorization failed (' . $e->getMessage() . '). Check logs and check if your domain is pointed correctly to this server.' );

$site_name = $domains[0];
$site_name = str_replace( '*.', '', $site_name );
Expand Down Expand Up @@ -641,18 +641,14 @@ private function executeRenewal( $domain, array $alternativeNames, $force = fals
return true;

} catch ( \Exception $e ) {
\EE::warning( 'A critical error occured during certificate renewal' );
\EE::warning( 'A critical error occurred during certificate renewal: ' . $e->getMessage() );
\EE::debug( print_r( $e, true ) );

\EE::warning( 'Challenge Authorization failed. Check logs and check if your domain is pointed correctly to this server.' );
\EE::log( 'You can fix the issue and re-run: ee site ssl-verify ' . $domains[0] );

return false;
} catch ( \Throwable $e ) {
\EE::warning( 'A critical error occured during certificate renewal' );
\EE::warning( 'A critical error occurred during certificate renewal: ' . $e->getMessage() );
\EE::debug( print_r( $e, true ) );

\EE::warning( 'Challenge Authorization failed. Check logs and check if your domain is pointed correctly to this server.' );
\EE::log( 'You can fix the issue and re-run: ee site ssl-verify ' . $domains[0] );

return false;
Expand Down
Loading