Repository navigation
feat(it): add engine start/stop/on phrases - #186
Merged
Merged
Conversation
it-IT was missing engsrt.wav/engstp.wav/engon.wav (engine start/stop/ on) - it only had engoff.wav (engine off). Adds all three using the same String IDs as en-US (465/466/467), matching the existing style of engoff.wav's "motore spento". it-IT.csv was previously fully sequential (1-267) with no gaps, and unlike fr-FR/pt-PT/uk-UA it wasn't in build_checks.py's WARNING_ONLY_FILES exemption list for the sequential-ID gap check. Using en-US's IDs directly creates a large gap (268-464), so it-IT.csv is added to that exemption list - the gap is now a warning instead of a hard CI error, consistent with how the other locale files with sparse ID coverage are already handled. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EwwCu3hzZwiDPjsd6HusQW
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EwwCu3hzZwiDPjsd6HusQW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SOUNDS/it/was missingengsrt.wav/engstp.wav/engon.wav(engine start/stop/on) — it only hadengoff.wav(engine off). English and several other locales already have all four.voices/it-IT.csvusing the same String IDs asen-US.csv(465/466/467), matching the existing style ofengoff.wav's "motore spento".it-IT.csvwas previously fully sequential with no gaps and wasn't inbuild_checks.py's gap-warning exemption list; adds it there (alongsidefr-FR.csv/pt-PT.csv/uk-UA.csv) since using en-US's IDs directly creates a large gap.Fixes #178
Test plan
uv run ./build_checks.pypasses with no errorsuv run pytestpasses (43/43)SOUNDS/it/engsrt.wav,engstp.wav,engon.wavpresent and generated via the standard TTS pipeline🤖 Generated with Claude Code
https://claude.ai/code/session_01EwwCu3hzZwiDPjsd6HusQW