-
Notifications
You must be signed in to change notification settings - Fork 14
AsterSeeds: add code to perturb neutron star #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jaykalinani
wants to merge
7
commits into
EinsteinToolkit:dev
Choose a base branch
from
jaykalinani:perturbNS
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
83bcdd5
Add NS perturbations and EOS-agnostic seed setters
jaykalinani 038acf4
Merge remote-tracking branch 'origin/dev' into perturbNS
jaykalinani c3cfdd3
Merge branch 'dev' into perturbNS
jaykalinani a945a7a
AsterSeeds: add UIUC dipole ID for single NS
jaykalinani 89bbb30
Merge remote-tracking branch 'upstream/dev' into perturbNS
jaykalinani 12cddcb
EOSX: add script and example for generating CompOSE tables
jaykalinani 5133623
EOSX: fix spelling to Composition_quadrupels as in the table
jaykalinani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -252,7 +252,7 @@ if (CCTK_Equals(test_type, "TabEOSTest")) { | |
|
|
||
| #Initial conditions for temperature, entropy and Ye | ||
|
|
||
| if (set_Ye_postinitial) { | ||
| if (set_Ye_postinitial && !CCTK_Equals(evolution_eos, "Tabulated3d")) { | ||
| SCHEDULE SetYe IN HydroBaseX_PostInitial | ||
| { | ||
| LANG: C | ||
|
|
@@ -261,22 +261,89 @@ if (set_Ye_postinitial) { | |
| } "Set initial Ye" | ||
| } | ||
|
|
||
| if (set_temperature_postinitial) { | ||
| SCHEDULE SetTemp IN HydroBaseX_PostInitial AFTER SetYe | ||
| { | ||
| LANG: C | ||
| READS: HydroBaseX::rho(everywhere) HydroBaseX::eps(everywhere) HydroBaseX::Ye(everywhere) | ||
| WRITES: HydroBaseX::temperature(everywhere) HydroBaseX::eps(everywhere) | ||
|
|
||
| } "Set initial temperature" | ||
| if (set_temperature_postinitial && !CCTK_Equals(evolution_eos, "Tabulated3d")) { | ||
| if (set_Ye_postinitial) { | ||
| SCHEDULE SetTemp IN HydroBaseX_PostInitial AFTER SetYe | ||
| { | ||
| LANG: C | ||
| READS: HydroBaseX::rho(everywhere) HydroBaseX::eps(everywhere) HydroBaseX::Ye(everywhere) | ||
| WRITES: HydroBaseX::temperature(everywhere) HydroBaseX::eps(everywhere) | ||
|
|
||
| } "Set initial temperature" | ||
| } else { | ||
| SCHEDULE SetTemp IN HydroBaseX_PostInitial | ||
| { | ||
| LANG: C | ||
| READS: HydroBaseX::rho(everywhere) HydroBaseX::eps(everywhere) HydroBaseX::Ye(everywhere) | ||
| WRITES: HydroBaseX::temperature(everywhere) HydroBaseX::eps(everywhere) | ||
|
|
||
| } "Set initial temperature" | ||
| } | ||
| } | ||
|
|
||
| if (set_entropy_postinitial) { | ||
| SCHEDULE SetEntropy IN HydroBaseX_PostInitial AFTER SetTemp | ||
| { | ||
| LANG: C | ||
| READS: HydroBaseX::rho(everywhere) HydroBaseX::eps(everywhere) HydroBaseX::Ye(everywhere) | ||
| WRITES: HydroBaseX::entropy(everywhere) HydroBaseX::eps(everywhere) | ||
|
|
||
| } "Set initial entropy" | ||
| if (set_entropy_postinitial && !CCTK_Equals(evolution_eos, "Tabulated3d")) { | ||
| if (set_temperature_postinitial) { | ||
| SCHEDULE SetEntropy IN HydroBaseX_PostInitial AFTER SetTemp | ||
| { | ||
| LANG: C | ||
| READS: HydroBaseX::rho(everywhere) HydroBaseX::eps(everywhere) HydroBaseX::Ye(everywhere) | ||
| WRITES: HydroBaseX::entropy(everywhere) HydroBaseX::eps(everywhere) | ||
|
|
||
| } "Set initial entropy" | ||
| } else if (set_Ye_postinitial) { | ||
| SCHEDULE SetEntropy IN HydroBaseX_PostInitial AFTER SetYe | ||
| { | ||
| LANG: C | ||
| READS: HydroBaseX::rho(everywhere) HydroBaseX::eps(everywhere) HydroBaseX::Ye(everywhere) | ||
| WRITES: HydroBaseX::entropy(everywhere) HydroBaseX::eps(everywhere) | ||
|
|
||
| } "Set initial entropy" | ||
| } else { | ||
| SCHEDULE SetEntropy IN HydroBaseX_PostInitial | ||
| { | ||
| LANG: C | ||
| READS: HydroBaseX::rho(everywhere) HydroBaseX::eps(everywhere) HydroBaseX::Ye(everywhere) | ||
| WRITES: HydroBaseX::entropy(everywhere) HydroBaseX::eps(everywhere) | ||
|
|
||
| } "Set initial entropy" | ||
| } | ||
| } | ||
|
|
||
| if (!CCTK_Equals(ns_perturbation_mode, "none")) { | ||
| if (CCTK_Equals(evolution_eos, "Tabulated3d")) { | ||
| SCHEDULE AsterSeeds_PerturbNS IN HydroBaseX_PostInitial AFTER ID_TabEOS_HydroQuantities_recompute_HydroBase_variables | ||
| { | ||
| LANG: C | ||
| READS: HydroBaseX::rho(everywhere) HydroBaseX::eps(everywhere) HydroBaseX::press(everywhere) HydroBaseX::temperature(everywhere) HydroBaseX::Ye(everywhere) | ||
| WRITES: HydroBaseX::rho(everywhere) HydroBaseX::eps(everywhere) HydroBaseX::press(everywhere) HydroBaseX::temperature(everywhere) HydroBaseX::entropy(everywhere) | ||
| } "Apply neutron-star pressure or density perturbation after tabulated-EOS hydro quantities" | ||
| } else if (set_entropy_postinitial) { | ||
| SCHEDULE AsterSeeds_PerturbNS IN HydroBaseX_PostInitial AFTER SetEntropy | ||
| { | ||
| LANG: C | ||
| READS: HydroBaseX::rho(everywhere) HydroBaseX::eps(everywhere) HydroBaseX::press(everywhere) HydroBaseX::temperature(everywhere) HydroBaseX::Ye(everywhere) | ||
| WRITES: HydroBaseX::rho(everywhere) HydroBaseX::eps(everywhere) HydroBaseX::press(everywhere) HydroBaseX::temperature(everywhere) HydroBaseX::entropy(everywhere) | ||
| } "Apply neutron-star pressure or density perturbation after hydro initial data" | ||
| } else if (set_temperature_postinitial) { | ||
| SCHEDULE AsterSeeds_PerturbNS IN HydroBaseX_PostInitial AFTER SetTemp | ||
| { | ||
| LANG: C | ||
| READS: HydroBaseX::rho(everywhere) HydroBaseX::eps(everywhere) HydroBaseX::press(everywhere) HydroBaseX::temperature(everywhere) HydroBaseX::Ye(everywhere) | ||
| WRITES: HydroBaseX::rho(everywhere) HydroBaseX::eps(everywhere) HydroBaseX::press(everywhere) HydroBaseX::temperature(everywhere) HydroBaseX::entropy(everywhere) | ||
| } "Apply neutron-star pressure or density perturbation after hydro initial data" | ||
| } else if (set_Ye_postinitial) { | ||
| SCHEDULE AsterSeeds_PerturbNS IN HydroBaseX_PostInitial AFTER SetYe | ||
| { | ||
| LANG: C | ||
| READS: HydroBaseX::rho(everywhere) HydroBaseX::eps(everywhere) HydroBaseX::press(everywhere) HydroBaseX::temperature(everywhere) HydroBaseX::Ye(everywhere) | ||
| WRITES: HydroBaseX::rho(everywhere) HydroBaseX::eps(everywhere) HydroBaseX::press(everywhere) HydroBaseX::temperature(everywhere) HydroBaseX::entropy(everywhere) | ||
| } "Apply neutron-star pressure or density perturbation after hydro initial data" | ||
| } else { | ||
| SCHEDULE AsterSeeds_PerturbNS IN HydroBaseX_PostInitial | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as above |
||
| { | ||
| LANG: C | ||
| READS: HydroBaseX::rho(everywhere) HydroBaseX::eps(everywhere) HydroBaseX::press(everywhere) HydroBaseX::temperature(everywhere) HydroBaseX::Ye(everywhere) | ||
| WRITES: HydroBaseX::rho(everywhere) HydroBaseX::eps(everywhere) HydroBaseX::press(everywhere) HydroBaseX::temperature(everywhere) HydroBaseX::entropy(everywhere) | ||
| } "Apply neutron-star pressure or density perturbation after hydro initial data" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this not be simplified to just say
SCHEDULE SetEntropy IN HydroBaseX_PostInitial AFTER SetTemp AFTER SetYe?