flake: Fix test_graceful_htlc to be flexible for notifs#9226
Merged
madelinevibes merged 1 commit intoJun 19, 2026
Merged
Conversation
madelinevibes
added
the
Status::Ready for Review
daywalker90
force-pushed
the
ddustin/test_graceful_htlc_flakefix
branch
from
d21a9c0 to
0d007bb
Compare
nGoline
reviewed
Jun 18, 2026
nGoline
left a comment
nGoline
left a comment
Collaborator
There was a problem hiding this comment.
Just a minor issue that might hide the real intent. Otherwise looks good.
madelinevibes
removed
the
Status::Ready for Review
ddustin
force-pushed
the
ddustin/test_graceful_htlc_flakefix
branch
from
0d007bb to
5951c81
Compare
The test_graceful_htlc test can receive an extra notification if the test is running slowly enough. This changes how the test looks at notifications by explicitly incrementing the notification index. Then, we make it notice and ignore the first RCVD_ADD_REVOCATION notification, which is unwanted in the test but can occur if the server is running slow enough. Changelog-None
madelinevibes
force-pushed
the
ddustin/test_graceful_htlc_flakefix
branch
from
5951c81 to
3204c71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test_graceful_htlc test can receive an extra notification if the test is running slowly enough.
This changes how the test looks at notifications by explicitly incrementing the notification index.
Then, we make it notice and ignore the first RCVD_ADD_REVOCATION notification, which is unwanted in the test but can occur if the server is running slow enough.
Fixes #9219