Skip to content

Adminer docker compose dev#1323

Open
valentinRyckaert wants to merge 4 commits into
ElixirTeSS:masterfrom
valentinRyckaert:adminer-docker-compose-dev
Open

Adminer docker compose dev#1323
valentinRyckaert wants to merge 4 commits into
ElixirTeSS:masterfrom
valentinRyckaert:adminer-docker-compose-dev

Conversation

@valentinRyckaert

Copy link
Copy Markdown

Summary of changes

  • PostgreSQL DB was not accessible by the host in Docker development mode (no binding with host port)
  • Added an Adminer instance on port 8080 to facilitate DB management/observations

Motivation and context

  • No possibility of having access to the database using Docker in development.

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree to license it to the TeSS codebase under the BSD license.

@kennethrioja kennethrioja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, else it works on my side! Thanks Valentin, this is very useful!

Comment thread docs/docker.md

<http://localhost:3000>


Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line

Comment thread docs/docker.md Outdated

### Access Adminer

An Adminer instance is accessible at the following URL:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add the link to Adminer https://www.adminer.org/
and add something like 'An Adminer instance to connect to and visualize your local database...'

Comment thread docker-compose.yml Outdated
volumes:
- db-data:/var/lib/postgresql/data
adminer:
image: adminer

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the container name and a specific release tag of adminer, e.g.:

    container_name: ${PREFIX}-adminer
    image: adminer:5.4.2

Comment thread docker-compose.yml
image: adminer:5.4.2
restart: always
ports:
- 8080:8080

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 8080:8080
- 8080:8080
depends_on:
- db

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one last suggestion I have before merging the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants