Preserve full shadow memtransfers#2872
Open
minansys wants to merge 1 commit into
Open
Conversation
Ensure reverse-mode shadow copies keep the full memtransfer when Enzyme also emits sliced shadow updates, so inactive pointer fields in copied aggregates remain initialized for later reverse use.
This was referenced Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem
Enzyme was zero-initializing a shadow copy of a struct and then copying only selected active slices from the source shadow. The reverse pass later needed pointer fields from the copied shadow object, but those fields stayed null. The fix preserves a full shadow memtransfer for nonzero memtransfers, so inactive pointer fields remain initialized while existing sliced updates can still run.
Summary
Test plan
LLVMEnzyme-19.soandClangEnzyme-19.soagainst the Conan LLVM 19.1.7 package.opt; confirmed the full 32-byte shadow copy is absent without the fix and present with the fix.TestAdjoint.UnitTestAdjointKWwith the minimal fix; it passed.#2629