Fix branch latest update on explicit remote sync - #152
Open
piyushbag wants to merge 1 commit into
Open
Conversation
When sync targets an explicit revision with --remote, propagate the remote search location into branch latest maintenance and store latest on the post-sync branch instead of the pre-sync branch. Fixes EpicGames#122 Signed-off-by: Piyush Jagadish Bag <piyushbag4@gmail.com>
piyushbag
force-pushed
the
fix/sync-explicit-remote-latest
branch
from
July 31, 2026 00:37
8825201 to
0343740
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes branch latest pointer maintenance when
lore sync <revision> --remotetargets an explicit revision.search_locationintolocationfor explicit revision sync so remote sync updates branch latest.synced_branch) instead of the pre-sync branch when callingstore_latest.Fixes #122
Test plan
cargo +nightly fmt --allcargo clippy -p lore-revision --all-targets -- -D warnings --no-depscargo test -p lore-revision sync_explicit_revisionEvidence
The test seeds a stale branch latest, syncs forward with
--remote, and asserts the latest pointer matches the synced revision.