Honor --dry-run when staging files - #153
Open
piyushbag wants to merge 1 commit into
Open
Conversation
Skip persisting staged anchors during dry-run while still emitting stage progress and revision events, matching commit and revert behavior. Fixes EpicGames#125 Signed-off-by: Piyush Jagadish Bag <piyushbag4@gmail.com>
piyushbag
force-pushed
the
fix/stage-dry-run-no-persist
branch
from
July 31, 2026 00:37
51801b9 to
f5db087
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lore stage --dry-runcomputed staged state but still persisted the staged anchor, so a later real stage reported "No changes staged" and commit could pick up the preview state.globals.dry_run()infile/stage.rsandstage.rs.Fixes #125
Test plan
cargo +nightly fmt --allcargo clippy -p lore-revision --all-targets -- -D warnings --no-depscargo test -p lore-revision --test stage stage_dry_run_no_persistEvidence
The test commits a baseline revision, modifies a tracked file, runs dry-run stage (no staged anchor persisted), then runs a real stage and verifies the staged anchor is written.