Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add android-sdk-framework module #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
feat: add android-sdk-framework module #251
Changes from 19 commits
b82fbbfbbb000345934db882786a79448179aa5bd6264661faa31c74d4f57b62099f505bda22e62fc396edb6b144e501d98d16eeb99dfdcb6bc6813639dad63ea660005d2ff509d03e0bfdc0d9cbde4f7c1e373c7f265600bf7884e151d8dFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 Comment from AI: This is the line that makes the snapshot publish path impossible for the new module. Since
versionis fixed at0.1.0,./gradlew :android-sdk-framework:publish -Psnapshotalways throws here (You cannot specify -Psnapshot with a non-SNAPSHOT version). Release publish is blocked too while theapidependency is still0.1.0-SNAPSHOT. Could we either make the module version0.1.0-SNAPSHOTuntil upstream is released, or derive the version from thesnapshot/releaseflag so the snapshot flow can actually publish?Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.