Reserve ergoplatform/ergo#2213 - unite p2sAddress and p2shAddress - #53
Closed
beejaygee wants to merge 2 commits into
Closed
Reserve ergoplatform/ergo#2213 - unite p2sAddress and p2shAddress#53beejaygee wants to merge 2 commits into
beejaygee wants to merge 2 commits into
Conversation
Contributor
Submission triage
Closing: stale reservation exceeded grace period. |
github-actions
Bot
added
the
stale-reservation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reserves ergoplatform/ergo#2213 for
beejaygee(100 SigUSD).Work already complete and submitted: ergoplatform/ergo#2454 — extracts the shared implementation behind
p2sAddressR/p2shAddressRinto a single helper. All 10 existing tests inScriptApiRouteSpecpass unchanged, verified in a sandboxed Docker build.Note: an earlier PR for this issue (#2250) got a maintainer approval but was closed unmerged without comment, and nothing has been open against it since.