Skip to content

Add support for nested SubMenus#1005

Merged
SnipUndercover merged 2 commits into
EverestAPI:devfrom
ACherryJam:add-nested-submenus
Jun 28, 2026
Merged

Add support for nested SubMenus#1005
SnipUndercover merged 2 commits into
EverestAPI:devfrom
ACherryJam:add-nested-submenus

Conversation

@ACherryJam

@ACherryJam ACherryJam commented Oct 4, 2025

Copy link
Copy Markdown
Contributor

Adds support for nested SubMenus.

Every SubMenu now stores a Parent submenu. If the Parent is null the submenu is added to TextMenu, Container's Focused, AutoScroll fields and MoveSelection method should be used. Otherwise we do the same things but for the Parent.
To keep parent SubMenu visible while not in focus, ItemsVisible flag was added.

Mod example: NestedSubMenuExample.zip

8mb.video-a8J-VS9ioLQK.mp4

@ACherryJam

ACherryJam commented Oct 4, 2025

Copy link
Copy Markdown
Contributor Author

I just realized this definitely conflicts with my last pull request. Should I worry about this or that's not my responsibility?

@maddie480-bot maddie480-bot added the 1: review needed This PR needs 2 approvals to be merged (bot-managed) label Oct 4, 2025
@Wartori54

Wartori54 commented Nov 29, 2025

Copy link
Copy Markdown
Member

Don't worry about conflicts until one of the two gets merged. We will simply rebase onto dev once one is merged.

@ACherryJam

ACherryJam commented Dec 3, 2025

Copy link
Copy Markdown
Contributor Author

Rebased the branch, ready for review.

@SnipUndercover SnipUndercover self-assigned this Dec 3, 2025
@SnipUndercover

SnipUndercover commented Dec 3, 2025

Copy link
Copy Markdown
Member

Assigning myself to remind myself to review this in the (hopefully near) future.

@SnipUndercover SnipUndercover mentioned this pull request Jan 3, 2026
Open
Wartori54
Wartori54 approved these changes Jun 23, 2026
View reviewed changes

@Wartori54 Wartori54 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed two tiny corrections, and with that LGTM!

@maddie480-bot

maddie480-bot commented Jun 23, 2026

Copy link
Copy Markdown
Member

The pull request was approved and entered the 3-day last-call window. Since no PR should be merged within 3 days of the next rolling release, the last-call window is extended further.
If no further reviews happen, it will end on Jun 28, 2026, 12:00 AM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Jun 23, 2026
@maddie480-bot

maddie480-bot commented Jun 28, 2026

Copy link
Copy Markdown
Member

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@maddie480-bot maddie480-bot added 4: ready to merge This PR was approved and the last-call window is over (bot-managed) and removed 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Jun 28, 2026
@SnipUndercover SnipUndercover merged commit c58f335 into EverestAPI:dev Jun 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DashingCat DashingCat DashingCat approved these changes
@Wartori54 Wartori54 Wartori54 approved these changes

Assignees

@SnipUndercover SnipUndercover

Labels

4: ready to merge This PR was approved and the last-call window is over (bot-managed)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ACherryJam @Wartori54 @SnipUndercover @maddie480-bot @DashingCat @microlith57 @maddie480