-
Notifications
You must be signed in to change notification settings - Fork 104
Wipe parsing #1053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Wipe parsing #1053
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4c4e803
Implement CustomWipe attribute
SilverDorian46 ea2f04d
Rename "ApplyWipe" to "ParseWipe" and remove AreaData parameter from …
SilverDorian46 ae90a8a
Merge branch 'dev' into wipe-parsing
SilverDorian46 78431cd
Split parse wipe condition with an `else if` for readability
SilverDorian46 856e02c
Specify the pattern in the summary for the attribute's ID
SilverDorian46 95083bb
Specify ID pattern in the summary for every Custom____Attribute
SilverDorian46 a8641d0
Update with changes from `dev`
SilverDorian46 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| using System; | ||
|
|
||
| namespace Celeste.Mod.Entities; | ||
|
|
||
| /// <summary> | ||
| /// Mark this renderer as a custom <see cref="ScreenWipe"/> with an identifier. | ||
| /// <br/> | ||
| /// This Screen Wipe will be applied if the map's Wipe metadata has a matching value. | ||
| /// <br/> | ||
| /// If there is no match, then the full type name of the Screen Wipe is checked for. | ||
| /// </summary> | ||
| [AttributeUsage(AttributeTargets.Class, AllowMultiple = false, Inherited = false)] | ||
| public class CustomWipeAttribute : Attribute { | ||
|
|
||
| /// <summary> | ||
| /// A list of unique identifiers for this Screen Wipe.<br/> | ||
| /// Follows the pattern "ID [= LoadMethodName]". | ||
| /// </summary> | ||
| public string[] IDs; | ||
|
|
||
| /// <summary> | ||
| /// Mark this renderer as a custom <see cref="ScreenWipe"/> with an identifier.<br/> | ||
| /// If there is no match, then the full type name of the Screen Wipe is checked for. | ||
| /// </summary> | ||
| /// <param name="ids"> | ||
| /// A list of unique identifiers for this Screen Wipe.<br/> | ||
| /// Follows the pattern "ID [= LoadMethodName]". | ||
| /// </param> | ||
| public CustomWipeAttribute(params string[] ids) { | ||
| IDs = ids; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: can the
Action<Scene, bool, Action>be a nameddelegatetype instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may just be my experience, but getting an
Actionand a delegate to work together like this is kind of tricky.so I thought just using an
Actionwould be easier