fix: remove debug console.log statements from plugin commands and targets#890
fix: remove debug console.log statements from plugin commands and targets#890kuishou68 wants to merge 3 commits into
Conversation
Removed 3 debug console.log statement(s). Co-authored-by: cocoon <54054995+kuishou68@users.noreply.github.com>
Removed 1 debug console.log statement(s). Co-authored-by: cocoon <54054995+kuishou68@users.noreply.github.com>
Removed 1 debug console.log statement(s). Co-authored-by: cocoon <54054995+kuishou68@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78d7dbb97b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // Plugin path goes to stdout (for scripting); usage hint goes to stderr | ||
| console.error(`\nReady. Use with:\n claude --plugin-dir ${pluginPath}\n`) |
There was a problem hiding this comment.
When plugin-path succeeds, the only machine-readable result used by documented shell aliases is stdout ($(ce-cli plugin-path ...) in README.md), and the comment immediately above this block still says the path goes to stdout. Removing this line makes stdout empty, so callers pass an empty --plugin-dir even though the clone/update succeeded; tests/plugin-path.test.ts also asserts stdout.trim() is the plugin directory.
Useful? React with 👍 / 👎.
| if (plugins.length === 0) { | ||
| console.log("No Claude plugins found under plugins/.") | ||
| return | ||
| } | ||
|
|
||
| console.log(plugins.sort().join("\n")) | ||
| }, |
There was a problem hiding this comment.
For workspaces that do contain plugin manifests, this command now builds plugins and then exits without printing anything, so bun run ... list always has empty stdout. That breaks the command's purpose and the existing CLI coverage in tests/cli.test.ts, which expects a temp workspace with plugins/demo-plugin/.claude-plugin/plugin.json to output demo-plugin.
Useful? React with 👍 / 👎.
1 participant
Description
Remove debug
console.logstatements that were accidentally left in the codebase. These produce noisy output during normal plugin operation.Changes
src/commands/list.ts: Removed debug console.log statementssrc/commands/plugin-path.ts: Removed debug console.log statementsrc/targets/kiro.ts: Removed debug console.log statementMotivation
Debug logging via
console.logclutters plugin output and should be removed for production use. If structured logging is needed, the project's logging utility should be used instead.Closes #889