-
-
Notifications
You must be signed in to change notification settings - Fork 47
feat: implement document embedding CLI command with comprehensive chunking and OpenAI integration #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
priyankeshh
wants to merge
18
commits into
main
Choose a base branch
from
feat/document-embedding-cli
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: implement document embedding CLI command with comprehensive chunking and OpenAI integration #138
Changes from 17 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
0a77a9d
feat: implement documents embed CLI command
priyankeshh 400b067
demo: add comprehensive demonstration of embed command functionality
priyankeshh 93c7d02
refactor: organize test files and create integration testing suite
priyankeshh 2f63419
docs: add comprehensive testing documentation and instructions
priyankeshh b5b1d33
test: complete end-to-end validation of embed functionality with real…
priyankeshh b06f6df
feat: implement configurable embedding system with random vectors
priyankeshh 8fc7d08
feat: enhance embedding functionality and improve document processing
JonnyTran b1ffa82
Apply ruff formatting
priyankeshh 95dd534
Add PyMuPDF integration with document metadata in extralit-server
priyankeshh dcf53e0
fix: address review feedback - proper dataset creation, remove test f…
priyankeshh 8138efd
refactor: minimize code and remove llama-index dependency
priyankeshh 7a765d2
style: apply pre-commit formatting
priyankeshh d875219
fix: simplify RQ job to use HF space service for margin lookup
priyankeshh eb415ee
fix: remove redundant PyMuPDF job definition from extralit-server
priyankeshh 1b39f1f
fix: simplify table context to follow existing workflow patterns
priyankeshh 7321381
fix: fetch analysis metadata from document for table extraction
priyankeshh fd1b9e9
Merge branch 'develop' into feat/document-embedding-cli
priyankeshh 9faff49
chore: remove redundant ocr/tables.py (functionality already in workf…
priyankeshh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -161,4 +161,5 @@ extralit/site | |
| **/*.db | ||
| .claude/ | ||
| output/ | ||
| output/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be deleted since it's just calling
extralit_ocr.jobs.pymupdf_to_markdown_job, which is already called in the workflows/documents.py fileThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@priyankeshh Please also address this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JonnyTran ,
I've completed the 2 tasks you assigned this week:
However, I'm running into issues with the embed CLI testing flow and could use your guidance:
Problem: Unable to run the embed CLI command successfully to test the full workflow (markdown-processed PDF → segments/chunks → Dataset records → annotation interface → similarity search)
Command I'm trying:
extralit documents add --workspace priyankesh-test --reference paper-001 --file .\document.mdError encountered:
What I've tried following your environment advice:
Current blocker: The server connection issue is preventing me from testing the complete flow: embed CLI → create records → annotation interface → Extralit SDK similarity search.
Could you help me troubleshoot this server connectivity issue? I want to ensure the development environment and server setup are correct before proceeding with the full workflow testing.
Thanks!
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @priyankeshh,
I think the
extralit documents addcommand is not working and it's not the preferred way to add documents. It only support PDF files upload and not .md files anyways. (I just made a PR #152 to fix it)The preferred way is the bulk upload documents on the web interface or the
extralit documents importCLI function where you provide the bib file and a directory to the PDF files. I sent some example files to you awhile ago on Slack.You can test if the CLI cmds like
extralit documents list -w priyankesh-testworks to check connection to the server, and if not connected, useextralit login --api-urlfirst.Let me know if you have other issues setting up the server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @priyankeshh, I just fixed the
extralit documents addCLI function in this commit. Upon upload it will run the document workflows so it'll be easy to test it this way