Skip to content

"Working with Binaries" contains error #58

Description

@bvdh

Not sure this belong here but I trust it will reach the correct party.

On the page "Working with Binaries - Guidance for FHIR IG Creation v0.1.0" it states:

Create the resource as per normal

  • For the attachment element, leave the data out, and provide only an id and contentType the id has the special value "ig-loader-[filename]", where filename is the name of the file to load. e.g. "id" : "ig-loader-MyLibrary.cql" (case sensitive)
  • The IG Publisher will scan all the folders identified by the path-binary parameter, and remove the id property, and replace with with the content from the file
  • If a matching file cannot be found, the id will be left in place, and an error will be logged in the qa page

The publisher code only processes binary inclusion for Attachments with one element: 'id'. The content-type is auto-populated. When content-type is added, the binary inclusion is not processed.

Please correct the language to:

Create the resource as per normal

  • For the attachment element, leave the data out, and provide only an id and contentType the id has the special value "ig-loader-[filename]", where filename is the name of the file to load. e.g. "id" : "ig-loader-MyLibrary.cql" (case sensitive)
  • The IG Publisher will scan all the folders identified by the path-binary parameter, and remove the id property, and replace with with the content from the file
  • If a matching file cannot be found, the id will be left in place, and an error will be logged in the qa page

And add a validation message to signal that the id is formatted to replace with binary and this requires that only an 'id' is included.

In the code this is handled in AdjunctFileLoader.java:232

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions