Fix: Explicitly export public API in factory/__init__.py using __all__#1154
Closed
bartektrybala wants to merge 1 commit into
Closed
Fix: Explicitly export public API in factory/__init__.py using __all__#1154bartektrybala wants to merge 1 commit into
bartektrybala wants to merge 1 commit into
Conversation
|
There's actually already a PR for these changes here. It just unfortunately hasn't been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the
__all__list tofactory/__init__.py.Why is this necessary?
Currently, strict type checkers (like Pyright or mypy) and modern IDEs throw an error when importing elements like
LazyFunctiondirectly fromfactory(e.g.,"LazyFunction" is not exported from module "factory").Explicitly defining
__all__resolves these warnings and properly defines the public API of the module without changing any underlying functionality.Checklist: