chore(deps): bump @inquirer/prompts from 7.10.1 to 8.5.2 - #1450
chore(deps): bump @inquirer/prompts from 7.10.1 to 8.5.2#1450dependabot[bot] wants to merge 2 commits into
Conversation
Bumps [@inquirer/prompts](https://github.com/SBoudrias/Inquirer.js) from 7.10.1 to 8.5.2. - [Release notes](https://github.com/SBoudrias/Inquirer.js/releases) - [Commits](https://github.com/SBoudrias/Inquirer.js/compare/@inquirer/prompts@7.10.1...@inquirer/prompts@8.5.2) --- updated-dependencies: - dependency-name: "@inquirer/prompts" dependency-version: 8.5.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
alfred-openspec
left a comment
There was a problem hiding this comment.
This major bump does not compile: Inquirer 8 no longer accepts the instructions property used in src/commands/config.ts, so lint and tests fail on every platform. Please adapt the prompt implementation with focused compatibility coverage and update the Nix dependency hash.
Code review — verdict: do not merge as-is; needs a code change firstThis is the one genuinely broken PR in the dependabot batch. Every test job plus The failure
The call site is const selectedWorkflows = await checkbox<string>({
message: 'Select workflows to make available:',
instructions: 'Space to toggle, Enter to confirm', // <-- removed in v8
pageSize: ALL_WORKFLOWS.length,
theme: { icon: { checked: '[x]', unchecked: '[ ]' } },
choices: ALL_WORKFLOWS.map(formatWorkflowChoice),
});I confirmed this directly against the published package rather than inferring it from the error. So customization moved under Assessment against the review criteria
Engine floors are OK, for the record — v8 requires RecommendationEither:
Whichever route, it also needs the Of the six dependabot PRs open right now, this is the only one with a substantive problem — the other four lockfile bumps just need the hash. |
|
Closing this — the v8 upgrade needs a code migration, not a version bump, so dependabot can't land it. Two blockers, both verified against the published packages:
Tracked properly in #1458 with the full checklist, including the Windows keypress regression risk in Not urgent — @dependabot ignore this major version |
|
OK, I won't notify you about version 8.x.x again, unless you re-open this PR. |
…sion-AI#1457) * chore(deps): consolidate dependabot bumps (typescript 6, @types/node 26, ora 9, commander, posthog-node) Replaces Fission-AI#1448, Fission-AI#1451, Fission-AI#1452 and Fission-AI#1453 with a single lockfile resolution. Each of those PRs changed pnpm-lock.yaml, so merging them serially would invalidate the flake.nix pnpmDeps hash four times over. - typescript 5.9.3 -> 6.0.3 (Fission-AI#1452) - @types/node 24.2.0 -> 26.x (Fission-AI#1451) - ora 8.2.0 -> 9.4.1 (Fission-AI#1453) - commander 14.0.0 -> 14.0.3, posthog-node 5.46.0 -> 5.46.1 (Fission-AI#1448, lockfile only) Fission-AI#1450 (@inquirer/prompts 8) is deliberately excluded: it needs a code migration, not a version bump. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * chore(nix): update pnpmDeps hash for bumped lockfile Hash taken from this PR's first Nix Flake Validation run. Note it differs from the hash any individual dependabot PR would have produced -- the combined lockfile resolves to its own content hash. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * chore(deps): align @types/node with the Node 20.19 runtime floor Addresses review feedback: compiling against Node 26 declarations lets the type checker admit APIs that are unavailable on the runtimes OpenSpec actually supports (engines: node >=20.19.0). Pins @types/node to ^20.19.43, the latest release in the line matching the declared floor. This also corrects a pre-existing drift -- main was on @types/node 24 against the same 20.19 floor, so the types were already ahead of the supported runtime before this PR. Verified: build clean, tsc --noEmit clean, eslint clean, 112 files / 2253 tests passing, dist/ emit byte-identical to origin/main, and no peer dependency warnings. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * chore(nix): update pnpmDeps hash for the realigned lockfile The @types/node downgrade to the 20.19 line changed the dependency set again (it pulls undici-types 6.21.0), so the previous hash no longer matches. Value taken from a forced-mismatch Nix run on this branch. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Bumps @inquirer/prompts from 7.10.1 to 8.5.2.
Release notes
Sourced from @inquirer/prompts's releases.
... (truncated)
Commits
bfd8710chore: Publish new release55cc5f3feat: add reusable package lint CLI3af9ed0test(inquirer): capture prompt runner output4381857fix(@inquirer/input): remove stale lint suppression45df331fix(@inquirer/external-editor): harden editor temp filesadef323chore: limit CI token permissionsb43359dchore: Publish new release24ecae2chore: fix yarn.lockb078d97fix: validate package engine compatibility3a49f9fchore(deps-dev): Bump oxfmt in the formatting group (#2143)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)