[TASK] Add option to disable translation fallback in menus#1499
Open
mbrodala wants to merge 1 commit into
Open
[TASK] Add option to disable translation fallback in menus#1499mbrodala wants to merge 1 commit into
mbrodala wants to merge 1 commit into
Conversation
Contributor
Author
|
(Build failure is unrelated.) |
Contributor
|
@mbrodala Can you do a rebase of this? |
mbrodala
force-pushed
the
menu-normal-when-no-language
branch
2 times, most recently
from
c1cf041 to
555e329
Compare
Contributor
Author
|
Done. |
NamelessCoder
requested changes
Oct 31, 2018
NamelessCoder
left a comment
NamelessCoder
left a comment
Member
There was a problem hiding this comment.
We need a strategy that moves us around the issue of signature changes for menu-related methods...
| $includeMenuSeparator = false, | ||
| $disableGroupAccessCheck = false | ||
| $disableGroupAccessCheck = false, | ||
| $normalWhenNoLanguage = false |
Member
There was a problem hiding this comment.
We have a couple of other patches which all try to change the method signature for getMenu which in turn affects any ViewHelper using menu functions. I'm extremely hesitant to change this bit unless it gets changed to a way that will prevent future signature changes, which means either:
- Implementing a DTO that contains menu configuration instructions.
- Or replacing this with whichever core method allows us to read a menu without rendering it as HTML.
But I don't think we should open the flood gates for this signature change because it's going to happen again and again, and the signature will become bloated. It's already pretty bad...
NamelessCoder
force-pushed
the
development
branch
3 times, most recently
from
7b35850 to
50d769b
Compare
NamelessCoder
force-pushed
the
development
branch
5 times, most recently
from
6dec417 to
74596bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1498