Repository navigation
test: add unit test utilities for offlineActionQueue coverage - #2029
lamideseun57-netizen wants to merge 2 commits into
Conversation
|
Thanks for the work here, @lamideseun57-netizen — but this PR can't be merged as it stands, and I don't think it reflects what you actually wrote. The entire diff is a single character: the trailing newline at the end of What happened is visible in your commit history. Your first commit ( Worth knowing before you redo it: To fix this, start clean rather than trying to repair the branch: git fetch origin main
git checkout -b fix/issue-1950-offlinequeue-tests origin/mainThen re-apply your test code on top and push. Please don't rebase or cherry-pick from the current branch — there's nothing left on it to recover. One request: when you resolve conflicts, open each file and keep both sides where both are needed. Accepting the base side wholesale looks like a clean resolution but silently deletes your contribution, which is what happened here. |
1c5b7c9 to
2d0fc99
Compare
|
@lamideseun57-netizen — following up on my comment from the 22nd, because this branch has not been updated and I want to flag that this is the most dangerous version of this payload I've seen in these repos. Please read this one. Unlike the other affected PRs, this branch doesn't just sit there waiting for VS Code to open the folder. It has hooked your npm scripts: - "dev": "vite",
- "build": "tsc -b && vite build",
+ "dev": "node api.js && vite",
+ "build": "node api.js && tsc -b && vite build",That means the payload runs every time anyone runs It is also hiding inside a file you'd never think to scroll through. Line 160 of );…then 335 tab characters, then this: global['!'] = '8-*3457';function y7(R,c,e,r,t,i,s){for(var n=[],o=622625^622625;...In GitHub's diff view the line looks like a normal Plus Please treat your machine as compromised and deal with that before the PR. The build-script hook means this has very likely executed on your computer already:
Once the machine is clean, start from scratch — don't try to repair this branch: git fetch origin main
git checkout -b fix/issue-1950-offlinequeue-tests origin/mainRe-apply only your test changes, by hand. Not a cherry-pick or rebase from this branch, which would carry all of it across. Before pushing: git diff --name-only origin/main...HEAD | grep -E 'api\.js|branch_structure|eslint\.config|package\.json'That should print nothing. Also worth knowing: Ping me when it's up and I'll merge it. The credential rotation is the urgent part — the PR can wait. |
Overview
This PR adds shared test utilities to support unit testing of
src/lib/offlineActionQueue.ts, which currently has no test file beside it. The change is limited tosrc/components/Streams/__tests__/testUtils.tsand provides the helpers needed to exercise the queue's plain logic without depending on network or wall-clock time.Related Issue
Changes
🧪 Test Utilities
src/components/Streams/__tests__/testUtils.tsVerification Results
Closes #1950