Skip to content

Improve password store detection on Linux tiling WMs #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BlueManCZ wants to merge 1 commit into
base: master
Choose a base branch
from
+27 −0
Open

Improve password store detection on Linux tiling WMs #2660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions app/src/browser/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,33 @@ const start = () => {
app.commandLine.appendSwitch('autoplay-policy', 'no-user-gesture-required');
app.commandLine.appendSwitch('js-flags', '--harmony');

// On Linux, Electron may fail to detect the correct password storage backend
// on non-GNOME/KDE desktops (e.g. Hyprland, Sway, i3). If the user hasn't
// explicitly set --password-store, check if a Secret Service provider is
// available on D-Bus and use gnome-libsecret.
if (
process.platform === 'linux' &&
!process.argv.some(arg => arg.startsWith('--password-store'))
) {
try {
const { execFileSync } = require('child_process');
const output = execFileSync('dbus-send', [
'--session',
'--dest=org.freedesktop.DBus',
'--type=method_call',
'--print-reply',
'/org/freedesktop/DBus',
'org.freedesktop.DBus.NameHasOwner',
'string:org.freedesktop.secrets',
], { timeout: 2000, encoding: 'utf8' });
if (output.includes('boolean true')) {
app.commandLine.appendSwitch('password-store', 'gnome-libsecret');
}
} catch (e) {
// D-Bus query failed — let Electron use its default backend
}
}

const options = parseCommandLine(process.argv);
global.errorLogger = setupErrorLogger(options);
const configDirPath = setupConfigDir(options);
Expand Down