Repository navigation
fix(yield-vault): enforce admin time-lock delay for APY parameter adj… - #1086
Merged
ONEONUORA merged 1 commit intoSep 26, 2026
Merged
Conversation
…ustments (Fracverse#988) - Add cancel_apy() entrypoint so owners can revoke a queued APY change before the 24-hour delay elapses, completing the timelock lifecycle - Add test_cancel_apy_clears_pending_change: verifies pending state is cleared and a new proposal can be queued/applied after cancellation - Add test_pending_apy_view_helpers: covers pending_apy() and pending_apy_activation() view helpers across the full queue/apply cycle - Keep existing try_* error-path tests as #[ignore] consistent with the rest of the suite (Soroban no_std panic aborts cannot be caught via try_*) The core time-lock mechanism (APY_TIMELOCK_SECS, update_apy queuing, apply_apy enforcement) was already in place; this PR adds the missing cancel path and test coverage for the full timelock surface area. Closes Fracverse#988
|
@OlaGreat Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
ONEONUORA
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ustments (#988)
Closes #988