Fix: Hide 'Minimize to system tray' setting on Wayland

[Shadorc]

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

closes #9187

Description

Wayland does not have a 'minimize' event (see electron/electron#51766 (comment)).
FreeTube can't really do anything on its side, nor can Electron.
Similar to MacOS, the fix is to hide this setting if Wayland is detected.

Testing

Linux Wayland

1. Execute FreeTube on Linux Wayland
2. Check that 'Minimize to tray' setting is hidden

Linux Wayland with compatibility mode

1. Execute FreeTube on Linux Wayland with --ozone-platform=x11
2. Check that 'Minimize to tray' setting is visible and working as intended

Windows

1. Execute FreeTube on Windows
2. Check that 'Minimize to tray' setting is visible and working as intended

[efb4f5ff-1298-471a-8973-3d47447115dc]

im wondering if we could just hide the setting when wayland is detected

[Shadorc]

I've spent some time searching to find out how to detect if we are using Wayland, but there doesn't seem to be a simple solution.
The standard approach is to rely on XDG_SESSION_TYPE, but as I mentioned in my issue, you can run Electron with --ozone-platform=x11 and it will work. This means we should also check for this argument.
There are people #9187 (comment) that use Wayland but seem to have their OS running FreeTube with X11 compatibility mode or something.
You can also use software like XWayland to run Wayland apps on an X11 server. It might change the XDG_SESSION_TYPE value correctly, but that seems like too many scenarios to implement something simple and reliable.

[Shadorc]

I've tested with two electron-based apps that I use: Discord and Signal.
They have a different approach, they both consider that "Minimize to system tray" can only occur when a user presses the close button, removing the app from the taskbar, not when minimizing.
According to signalapp/Signal-Desktop#5840 (comment), it is the same behaviour for Battle.net

[absidue]

The setting in FreeTube is explicitly designed to be minimize to system tray, not close to system tray. As for detecting wayland you can use the same approach as the existing code: https://github.com/FreeTubeApp/FreeTube/blob/development/src/main/index.js#L1163.

[Shadorc]

I apologize if I wasn't clear. I wasn't suggesting that FreeTube should mimic "close to system tray" behavior. I was simply providing examples of how other Electron apps handle the "Minimize to tray" setting. If any of those apps successfully minimized to the system tray like FreeTube does on X11, it could have indicated that a solution was possible.

Thanks for the code reference. As I mentioned in my concerns here, I wasn't sure it would cover all possible scenarios, but if you're confirming it does, that's great! I'll use it to hide the setting when it's unavailable.

[Shadorc]

I'm not sure what is happening with the CI, it builds on my side and yarn run lint-fix does not show any warning/error. It indicates "Module not found" for three different modules. I've rebased on development branch with no luck.

[absidue]

Looks like you accidentally added back the yarn.lock file but the development branch switched to pnpm a few weeks ago, so you probably need to rebase again after your reverts.