Fix: Watch time progress bar inconsistency#9267
Open
Shadorc wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 17, 2026
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
Member
There was a problem hiding this comment.
LGTM!
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
ChunkyProgrammer,
MarmadileManteater and
absidue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
closes #3530
Description
Playlist video information is gathered from Innertube with duration precision in seconds (see the references in YouTube.js and FreeTube). However, when watch progress is saved to the database, it uses the Shaka player's
getCurrentTime()method, which has millisecond precision. When calculating the watch progress percentage, the calculation divides milliseconds by seconds, for example, 1.412 / 2, which always results in a value less than 100% due to the unit mismatch.This introduces a small regression, but I have checked and it is exactly the same behaviour on YouTube: if you watch a video with a duration of 1.4s during 1s and close the video, it will be considered as fully watched. It is the same for all video durations, a second started is a second considered fully watched.
Screenshots
Testing
See reproduction steps in #3530