Fix redundant ops#7636
Merged
Merged
Conversation
Merging this PR will improve performance by 10.44%
Performance Changes
Tip Curious why this is faster? Comment Comparing |
3026b1f to
3d86c20
Compare
Member
|
👍 |
ironcev
reviewed
May 31, 2026
da9fcf1 to
7575fe5
Compare
JoshuaBatty
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have been considering any
NOOP, and others, as redundant, but in reality they are only redundant if their const def registers are not read by the immediate op.This PR takes this into consideration.
Checklist
Breaking*orNew Featurelabels where relevant.