Update seat allocation logic in random_algo for course and programme - #1938
Merged
vikrantwiz02 merged 1 commit intoJul 25, 2026
Merged
Conversation
…count registered students based on course and programme type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the seat allocation logic in the
random_algofunction to more accurately track already allotted seats and handle cases where no next priority registration is found. The most important changes are:Seat allocation accuracy:
seats_alloteddictionary is now initialized with the actual count ofFinalRegistrationentries matching the current course, semester, batch, and programme type, instead of always starting from zero. This ensures that the algorithm accounts for seats already allotted before running.Robustness in priority assignment:
.filter().first()instead of.get(), preventing exceptions if no matching registration is found. If no next registration exists, the remaining seat count (rem) is decremented accordingly, ensuring the algorithm doesn't get stuck or raise errors.