fix(ui): align field states and search affordances with the design system - #2906
Open
kev1n77 wants to merge 2 commits into
Open
fix(ui): align field states and search affordances with the design system#2906kev1n77 wants to merge 2 commits into
kev1n77 wants to merge 2 commits into
Conversation
Align light field borders and placeholder colors while preserving visible keyboard focus contrast, named theme palettes, and legacy imported overrides. Size search artwork through the existing Input slot, show shortcuts together with clear actions, and prevent clearing disabled or read-only fields. Keep all existing size tokens, size APIs, heights, and product size selections. Update Design Lab state examples, DOM regression coverage and generated theme projections. Validate with design-system:check, check:web, 48 product tests, and 22 focused component tests.
Use the dedicated field editing color for Input and SearchField so native focus-visible heuristics do not replace the light 20% border with dark gray. Remove Design Lab's additional focus shadow and keep the existing 1px border and all control geometry unchanged. Preserve dark and high-contrast focus colors and inherit explicit legacy Appearance focus overrides unless an editing color is supplied. Keep the stronger generic focus contract available to its other control consumers. Update theme projections and regression checks. Validation: design-system:check, check:web, and 21 focused product tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type and Areas
Type: Bug fix / UI/UX
Areas: Design system, Web UI, appearance compatibility, generated desktop and MiniApp theme assets
Motivation / Impact
Text fields used a stronger focus treatment than the intended editing state. Placeholder and icon colors also differed between shared controls and product themes.
Input and SearchField now use a single 1px active border, with 20% black in the default light theme. Shared control heights and size tokens remain unchanged. Search fields retain shortcut hints when a clear action is available and prevent clearing read-only values.
Verification
pnpm run design-system:check— passed.pnpm run check:web— appearance, typography, theme color, and visual contract checks passed; the final type check encountered missing generated UI declarations during concurrent builds.pnpm run type-check:web— passed on a sequential rerun.git diff --check— passed.Reviewer Notes
Checklist