-
Notifications
You must be signed in to change notification settings - Fork 106
Fix source statistics #4056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dkachuma
wants to merge
17
commits into
develop
Choose a base branch
from
dkachuma/fix-source-statistics
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix source statistics #4056
Changes from 7 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
9f50193
Fix MPI sync
dkachuma e5272e7
Merge branch 'develop' into dkachuma/fix-source-statistics
dkachuma 07de379
Sync times
dkachuma c21d3b0
Merge branch 'develop' into dkachuma/fix-source-statistics
dkachuma b9f8ba4
Trivial change
dkachuma e68749d
Trivial change
dkachuma 7de86dd
Merge branch 'develop' into dkachuma/fix-source-statistics
dkachuma 88f8da6
Merge branch 'develop' into dkachuma/fix-source-statistics
dkachuma b971c1b
Fix elemet count and add unit test
dkachuma 4f0b388
Add barrier call in testFlowStatistics setup
dkachuma 1b058d9
Merge branch 'develop' into dkachuma/fix-source-statistics
dkachuma a7f0894
Add comments explaining max() usage for period start time in SourceFl…
Copilot 0f9d25e
Merge branch 'develop' into dkachuma/fix-source-statistics
dkachuma 4be3033
Merge branch 'develop' into dkachuma/fix-source-statistics
dkachuma feb542f
Merge branch 'develop' into dkachuma/fix-source-statistics
jhuang2601 ff911a6
Merge branch 'develop' into dkachuma/fix-source-statistics
jhuang2601 001cd8c
Merge branch 'develop' into dkachuma/fix-source-statistics
dkachuma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can they be different over ranks?
Isn't
SourceFluxStatistics::gatherTimeStepStats()called synchonously?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for mpi ranks without cells in the region, there is a bypass at CompositionalMultiphaseBase.cpp:1813-1816 - haven't checked single phase, but probably the same thing. This means some of the processes don't get to call
SourceFluxStatistics::gatherTimeStepStats()and lag behind. Hence the need for a max.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Same thing, I would add a short comment to explain why this
max()call.