Fix LGV block API usage after upstream rename to displayedRegionIndex#802
Open
cmdcolin wants to merge 1 commit into
Open
Fix LGV block API usage after upstream rename to displayedRegionIndex#802cmdcolin wants to merge 1 commit into
cmdcolin wants to merge 1 commit into
Conversation
jbrowse-components renamed block.parentRegion to a displayedRegionIndex lookup and bpToPx's regionNumber param to displayedRegionIndex. Update all call sites to match. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses some breaking changes from jbrowse-components. Upstream jbrowse-components webgl-poc refactor removed block.parentRegion and changed it to just store 'displayedRegionIndex'. This concept was then applied broadly across several APIs. Instead of storing parentRegion, users can manually lookup view.displayedRegions[displayedRegionIndex]. This was try to to simplify and optimize the block generation code: it was running getSnapshot frequently on the region objects, etc.
Sort of similarly, we renamed bpToPx's
regionNumberattribute todisplayedRegionIndex.We could potentially add backcompat for the bpToPx thing, but it may not be worth it to add backcompat for parentRegion.
If it is desirable to maintain compat with v4 and v5 of jbrowse though in apollo, we could add backcompat layer for 1 or both these issues and close this PR