VisibilityQuery : Add node for querying scene visibility - #7137
Open
johnhaddon wants to merge 3 commits into
Open
VisibilityQuery : Add node for querying scene visibility#7137johnhaddon wants to merge 3 commits into
johnhaddon wants to merge 3 commits into
Conversation
This outputs a boolean to say if a location is visible or not, and also a list of all ancestors which are invisible.
murraystevenson
left a comment
murraystevenson
left a comment
Contributor
There was a problem hiding this comment.
Thanks John! This looks like a handy addition to the query nodes. I've noted one potential hashing issue inline, but otherwise this is looking good to me.
| void VisibilityQuery::hashInvisibleAncestors( const Gaffer::Context *context, IECore::MurmurHash &h ) const | ||
| { | ||
| ComputeNode::hash( invisibleAncestorsPlug(), context, h ); | ||
| hashAncestorVisibilityForLocation( context, h ); |
Contributor
There was a problem hiding this comment.
Do we also need to hash locationPlug() here? If I have two siblings "/group/sphere" & "/group/sphere1", both with scene:visible = False, changing the location plug from "/group/sphere" to "/group/sphere1" incorrectly shows "/group/sphere" in invisibleAncestors.
Fix hashing for `invisibleAncestors`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This outputs a boolean to say if a location is visible or not, and also a list of all ancestors which are invisible.