fix(social): Make CreateFriendship idempotent#20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
Microsoft.EntityFrameworkCore.DbUpdateExceptionoccurring whenCreateFriendshipis called multiple times for the same user pair, leading to a duplicate primary key violation in theFriendstable.The root cause was that
CreateFriendshipunconditionally attempted to insert a newFriendEntrywithout first checking for its existence. This could happen due to race conditions or repeated client requests.The solution implements a two-layer defense:
AnyAsync()check is added before insertion to prevent adding duplicate entries in most cases.catchblock is enhanced to specifically handleMySqlConnector.MySqlExceptionwith error code1062(ER_DUP_ENTRY). This ensures that if a race condition still leads to a duplicate insert attempt, the exception is silently ignored, as the desired state (friendship exists) has already been achieved by a concurrent operation.This makes the
CreateFriendshipmethod idempotent and prevents theDbUpdateException.Fixes SERVICES-3W