fix(database): Prevent duplicate primary key on daily stats day rollover#21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
Microsoft.EntityFrameworkCore.DbUpdateExceptionwith the inner exceptionMySqlConnector.MySqlException: Duplicate entry 'PRIMARY'occurring inDailyStatsManager.SaveToDB.The root cause was identified as the
g_StatsContainerstatic object retaining the previous day'sDayOfYearvalue. When a new calendar day began,SaveToDBwould correctly identify that no record existed for the current day, but then attempt to insertg_StatsContainerwhich still held the previous day'sDayOfYear. This led to a primary key violation because a record for the previous day already existed.The fix involves re-initializing
g_StatsContainerwithnew DailyStat()within theSaveToDBmethod'sentity == null(insert) branch. This ensures that when a new daily stats record is created,g_StatsContainer.DayOfYearis correctly set to the current day, preventing the duplicate key error.Additionally, the
TODO_EFCOREcomment regarding preserving oldON DUPLICATEbehavior has been removed, as this fix correctly handles the day rollover without needing specific upsert semantics.Fixes SERVICES-3M