Cosmetic enhancements to Supervisor.cpp#413
Open
AZero13 wants to merge 1 commit into
Open
Conversation
Those empty braces are ugly.
Contributor
|
I've been mulling over this one, and while I agree the empty braces are ugly, it would probably be better to leave them. I'm guessing the reason the code looks like this in the first place is because ZUN originally had code in those blocks, and then realized he didn't need that code and commented it out, assuming the compiler would be smart enough to not generate terrible code (unfortunately, MSVC is not a smart compiler.) Regarding the other changes, I am willing to merge those into the repo. It's a shame we don't have any versions of this code that were compiled with debug code gen to actually be able to tell for sure if those are of the form or of the form |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those empty braces are ugly.