Skip to content

Cosmetic enhancements to Supervisor.cpp#413

Open
AZero13 wants to merge 1 commit into
GensokyoClub:masterfrom
AZero13:nue
Open

Cosmetic enhancements to Supervisor.cpp#413
AZero13 wants to merge 1 commit into
GensokyoClub:masterfrom
AZero13:nue

Conversation

@AZero13

@AZero13 AZero13 commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Those empty braces are ugly.

Those empty braces are ugly.
@KSSBrawl

KSSBrawl commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

I've been mulling over this one, and while I agree the empty braces are ugly, it would probably be better to leave them. I'm guessing the reason the code looks like this in the first place is because ZUN originally had code in those blocks, and then realized he didn't need that code and commented it out, assuming the compiler would be smart enough to not generate terrible code (unfortunately, MSVC is not a smart compiler.)

Regarding the other changes, I am willing to merge those into the repo. It's a shame we don't have any versions of this code that were compiled with debug code gen to actually be able to tell for sure if those are of the form

else
{
    if (...
}

or of the form

else if (...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants