Repository navigation
PIPELINE-4286: Floor coordinates when building gridcode - #99
Merged
Merged
Conversation
The gridcode was formatted directly from the raw mean longitude/latitude, so rounding in the %.2f format could push an event into a neighbouring grid cell. Floor each coordinate to the 0.01 grid resolution first so the gridcode maps deterministically to its cell. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
tomaslink
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://globalfishingwatch.atlassian.net/browse/PIPELINE-4286
The
gridcodewas formatted directly from the rawmean_longitude/mean_latitude, so rounding in the%.2fformat could push an event into a neighbouring grid cell. This floors each coordinate to the 0.01 gridresolution before formatting, so the gridcode maps deterministically to its cell.
This is basically the same change we implemented on pipe-measures for this and we definitively need to extract this logic out so we can share it everywhere.
🤖 Generated with Claude Code