Add option to exclude open gaps from gap-events output - #147
Merged
Merged
Conversation
VMS doesn't want open gaps surfaced yet, since every run's last processed day naturally ends with an open-gap peak (expected, not a bug) that hasn't been decided on. --exclude-open-gaps lets a caller opt out of the open-gap inclusion fixed in #145, without reverting that fix for AIS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--exclude-open-gaps/GapEventsConfig.exclude_open_gaps(defaultfalse), which filters out open gaps (end_timestamp IS NOT NULL) from thegap-eventsoutput.product_eventssilently excluding every open gap. AIS wants them included, but VMS doesn't want open gaps surfaced yet — every run's last processed day naturally ends with an open-gap peak (expected, not a bug), and that hasn't been decided on for VMS. This option lets VMS opt back out without reverting the Fix gap-events silently excluding every open gap from product_events #145 fix for AIS.Test plan
test_exclude_open_gaps_defaults_to_false— unchanged default behaviortest_exclude_open_gaps_drops_them_from_the_output— flag actually filters open gapstests/pipelines/events+tests/clisuite passes (24 passed)