Added blank imports for data sources, ephemeral resources, and list resources#17753
Added blank imports for data sources, ephemeral resources, and list resources#17753melinath wants to merge 1 commit into
Conversation
6fe2590 to
432547b
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 432547b: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. 🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @melinath, @SirGitsalot VCR tests complete for 432547b! |
|
VCR failures look unrelated. |
|
@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 1 week. Please take a look! Use the label |
We need to also explicitly encode dependencies for other types of registered resources that are used in acceptance tests. This updates handwritten & generated test files to do so. Note: This changes the framing from "services" to "packages" because there are some test-only resources that are defined in non-service packages. Standardizing on "packages" / TestDependencies allows us more flexibility for cases like that. (I'm planning on adding imports for those other resources in a separate PR, along with certain resources that have non-standard names.)
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.