Skip to content

Added blank imports for data sources, ephemeral resources, and list resources#17753

Open
melinath wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
melinath:other-resource-type-blank-imports
Open

Added blank imports for data sources, ephemeral resources, and list resources#17753
melinath wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
melinath:other-resource-type-blank-imports

Conversation

@melinath
Copy link
Copy Markdown
Member

@melinath melinath commented May 27, 2026

We need to also explicitly encode dependencies for other types of registered resources that are used in acceptance tests. This updates handwritten & generated test files to do so. Note: This changes the framing from "services" to "packages" because there are some test-only resources that are defined in non-service packages. Standardizing on "packages" / TestDependencies allows us more flexibility for cases like that. (I'm planning on adding imports for those other resources in a separate PR, along with certain resources that have non-standard names.)

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@melinath melinath force-pushed the other-resource-type-blank-imports branch from 6fe2590 to 432547b Compare May 27, 2026 22:15
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 27, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 432547b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 257 files changed, 271 insertions(+)
google-beta provider View Diff 272 files changed, 286 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6475 5801 664 10
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccContainerCluster_withLoggingConfig
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataformConfig_update
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log ❌ Error · Log TestAccDataformConfig_update
❌ Error · Log - TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log - TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log - TestAccContainerCluster_withLoggingConfig
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@melinath, @SirGitsalot VCR tests complete for 432547b!

@melinath melinath requested a review from SirGitsalot May 27, 2026 22:26
@melinath
Copy link
Copy Markdown
Member Author

VCR failures look unrelated.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants