Skip to content

Update Saas resource in SaasRuntime with applicationTemplate property#17762

Open
neil-dey wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
neil-dey:main
Open

Update Saas resource in SaasRuntime with applicationTemplate property#17762
neil-dey wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
neil-dey:main

Conversation

@neil-dey
Copy link
Copy Markdown

@neil-dey neil-dey commented May 28, 2026

saasservicemgmt: added `applicationTemplate`, `blueprintRepo`, `conditions`, `error`, and `state` fields to `Saas` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 28, 2026
@neil-dey neil-dey marked this pull request as ready for review May 29, 2026 17:32
@github-actions github-actions Bot requested a review from slevenick May 29, 2026 17:32
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

type: NestedObject
description: |-
CompositeRef represents a reference to a composite resource.
Next ID: 4
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next ID?

description: |-
A set of conditions which indicate the various conditions this resource can
have.
output: true
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add output: true to all of the sub-fields of this

output: true
- name: error
type: NestedObject
output: true
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add output: true to all sub-fields


headers := make(http.Header)

// 1. Wait for the resource to transition out of STATE_RUNNING before deleting
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long does this reasonably take? Should we set limits here on how long to wait on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants