Skip to content

Add terraform support for biglake hive catalogs#17763

Open
holjen wants to merge 5 commits into
GoogleCloudPlatform:mainfrom
holjen:biglakehivecatalog
Open

Add terraform support for biglake hive catalogs#17763
holjen wants to merge 5 commits into
GoogleCloudPlatform:mainfrom
holjen:biglakehivecatalog

Conversation

@holjen
Copy link
Copy Markdown

@holjen holjen commented May 28, 2026

Fixes hashicorp/terraform-provider-google#27576

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_biglake_hive_catalog`

@github-actions github-actions Bot requested a review from hao-nan-li May 28, 2026 22:40
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 28, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8d6f4e8:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 13 files changed, 582 insertions(+)
google-beta provider View Diff 17 files changed, 2306 insertions(+)
terraform-google-conversion View Diff 5 files changed, 538 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6494 5813 664 17
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccBiglakeHiveHiveCatalogIamBindingGenerated
  • TestAccBiglakeHiveHiveCatalogIamMemberGenerated
  • TestAccBiglakeHiveHiveCatalogIamPolicyGenerated
  • TestAccBiglakeHiveHiveCatalog_biglakeHiveCatalogExample
  • TestAccBiglakeHiveHiveCatalog_biglakeHiveCatalogFullExample
  • TestAccBiglakeHiveHiveCatalog_biglakeHiveCatalog_update
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccContainerCluster_withLoggingConfig
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataformConfig_update
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccBiglakeHiveHiveCatalogIamBindingGenerated
✅ Log TestAccBiglakeHiveHiveCatalogIamMemberGenerated
✅ Log TestAccBiglakeHiveHiveCatalogIamPolicyGenerated
✅ Log TestAccBiglakeHiveHiveCatalog_biglakeHiveCatalogExample
✅ Log TestAccBiglakeHiveHiveCatalog_biglakeHiveCatalogFullExample
✅ Log TestAccBiglakeHiveHiveCatalog_biglakeHiveCatalog_update
✅ Log TestAccDataformConfig_update
✅ Log ❌ Error · Log TestAccProjectIamMemberRemove_memberInMultipleBindings
❌ Error · Log - TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log - TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log - TestAccContainerCluster_withLoggingConfig
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@holjen, @sachinpro, @hao-nan-li VCR tests complete for 8d6f4e8!

@holjen
Copy link
Copy Markdown
Author

holjen commented May 29, 2026

I'm not sure how to fix --- FAIL: TestValidateResourceMetadata (0.99s) allservices_test.go:297: resource_biglake_hive_catalog_generated_meta.yaml: api_version is required and not set I attempted to add it into resource file but that resulted in

  line 24: field api_version not found in type api.Resource
make: *** [GNUmakefile:54: mmv1] Error 1

Comment thread mmv1/products/biglakehive/HiveCatalog.yaml Outdated
versions:
- name: 'ga'
base_url: 'https://biglake.googleapis.com/'
- name: 'beta'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to double-check, GA and Beta are using the same hostname, basically means there's no diff between them?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes , I tried removing the GA, but it required it to be there when I tried making provider

@github-actions github-actions Bot requested a review from hao-nan-li May 29, 2026 18:27
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 29, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c472dea:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 13 files changed, 582 insertions(+)
google-beta provider View Diff 17 files changed, 2306 insertions(+)
terraform-google-conversion View Diff 5 files changed, 538 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6499 5825 664 10
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccContainerCluster_withLoggingConfig
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataformConfig_update
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccDataformConfig_update
❌ Error · Log - TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log - TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log - TestAccContainerCluster_withLoggingConfig
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@holjen, @sachinpro, @hao-nan-li VCR tests complete for c472dea!

@holjen
Copy link
Copy Markdown
Author

holjen commented Jun 2, 2026

@sachinpro @hao-nan-li hey could I get some guidance on how to resolve the api_version issue? Beta and GA both share the same base url, because the IAM policy uses a different one than catalog. Catalog needs to start with hive/v1beta while IAM needs to start with v1

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

@hao-nan-li This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Jun 3, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 642b48f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 13 files changed, 582 insertions(+)
google-beta provider View Diff 17 files changed, 2306 insertions(+)
terraform-google-conversion View Diff 5 files changed, 538 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6521 5841 664 16
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccBiglakeHiveHiveCatalogIamBindingGenerated
  • TestAccBiglakeHiveHiveCatalogIamMemberGenerated
  • TestAccBiglakeHiveHiveCatalogIamPolicyGenerated
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey
  • TestAccContainerCluster_withLoggingConfig
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataformConfig_update
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDatastreamConnectionProfile_sshKey_update
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeRouterPeer_AddMd5AuthenticationKey
✅ Log TestAccDatastreamConnectionProfile_sshKey_update
✅ Log TestAccProjectIamMemberRemove_memberInMultipleBindings
✅ Log ❌ Error · Log TestAccDataformConfig_update
❌ Error · Log - TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log - TestAccBiglakeHiveHiveCatalogIamBindingGenerated
❌ Error · Log - TestAccBiglakeHiveHiveCatalogIamMemberGenerated
❌ Error · Log - TestAccBiglakeHiveHiveCatalogIamPolicyGenerated
❌ Error · Log - TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log - TestAccContainerCluster_withLoggingConfig
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@holjen, @sachinpro, @hao-nan-li VCR tests complete for 642b48f!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support google_biglake_hive_catalog resource

3 participants