Add terraform support for biglake hive catalogs#17763
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8d6f4e8: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. 🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @holjen, @sachinpro, @hao-nan-li VCR tests complete for 8d6f4e8! |
|
I'm not sure how to fix |
| versions: | ||
| - name: 'ga' | ||
| base_url: 'https://biglake.googleapis.com/' | ||
| - name: 'beta' |
There was a problem hiding this comment.
Just to double-check, GA and Beta are using the same hostname, basically means there's no diff between them?
There was a problem hiding this comment.
Yes , I tried removing the GA, but it required it to be there when I tried making provider
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c472dea: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @holjen, @sachinpro, @hao-nan-li VCR tests complete for c472dea! |
|
@sachinpro @hao-nan-li hey could I get some guidance on how to resolve the api_version issue? Beta and GA both share the same base url, because the IAM policy uses a different one than catalog. Catalog needs to start with |
|
@hao-nan-li This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 642b48f: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. 🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @holjen, @sachinpro, @hao-nan-li VCR tests complete for 642b48f! |
Fixes hashicorp/terraform-provider-google#27576
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.