Skip to content

kms: resource identity support for crypto_key_version resource#17764

Open
BBBmau wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
BBBmau:identity-support-cryptoKeyVersion
Open

kms: resource identity support for crypto_key_version resource#17764
BBBmau wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
BBBmau:identity-support-cryptoKeyVersion

Conversation

@BBBmau
Copy link
Copy Markdown
Collaborator

@BBBmau BBBmau commented May 28, 2026

crypto_key_version needed specific logic due to it's custom_import code

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

kms: add resource identity support for `crypto_key_version`

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 28, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e39d7d8:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 58 insertions(+), 1 deletion(-)
google-beta provider View Diff 2 files changed, 58 insertions(+), 1 deletion(-)
terraform-google-conversion View Diff 1 file changed, 3 insertions(+)

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • kms

Please fix the compilation errors to complete your PR.

View the build log

@BBBmau VCR tests complete for e39d7d8!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 28, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f13133e:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 58 insertions(+), 1 deletion(-)
google-beta provider View Diff 2 files changed, 58 insertions(+), 1 deletion(-)
terraform-google-conversion View Diff 1 file changed, 3 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
52 45 6 1
Affected Service Packages
  • kms

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccKmsCryptoKeyVersion_importBlockWithResourceIdentity

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccKmsCryptoKeyVersion_importBlockWithResourceIdentity

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@BBBmau VCR tests complete for f13133e!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants