Skip to content

Re-enable networkPerformanceConfig test#17771

Merged
rileykarson merged 1 commit into
GoogleCloudPlatform:mainfrom
cwangVT:main
Jun 2, 2026
Merged

Re-enable networkPerformanceConfig test#17771
rileykarson merged 1 commit into
GoogleCloudPlatform:mainfrom
cwangVT:main

Conversation

@cwangVT
Copy link
Copy Markdown
Contributor

@cwangVT cwangVT commented May 31, 2026

re-enable failed test in hashicorp/terraform-provider-google#24850

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@github-actions github-actions Bot requested a review from SirGitsalot May 31, 2026 00:34
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 31, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6e53edc:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 4 deletions(-)
google-beta provider View Diff 1 file changed, 4 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
293 275 15 3
Affected Service Packages
  • container

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccContainerCluster_networkPerformanceConfig
  • TestAccContainerCluster_withLoggingConfig
  • TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccContainerCluster_networkPerformanceConfig
❌ Error · Log - TestAccContainerCluster_withLoggingConfig
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@cwangVT, @SirGitsalot VCR tests complete for 6e53edc!

@cwangVT
Copy link
Copy Markdown
Contributor Author

cwangVT commented May 31, 2026

The failed tests:

TestAccContainerCluster_withLoggingConfig
TestAccContainerNodePool_withHostMaintenancePolicy

are already failing, and should not related to this PR

@rileykarson rileykarson added this pull request to the merge queue Jun 2, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 7629104 Jun 2, 2026
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants