Skip to content

feat(chronicle): Add Terraform support for Chronicle Parser#17774

Open
govisingh-dotcom wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
govisingh-dotcom:chronicle-parser-only-govisingh
Open

feat(chronicle): Add Terraform support for Chronicle Parser#17774
govisingh-dotcom wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
govisingh-dotcom:chronicle-parser-only-govisingh

Conversation

@govisingh-dotcom
Copy link
Copy Markdown

@govisingh-dotcom govisingh-dotcom commented Jun 1, 2026

This PR adds the google_chronicle_parser resource in GA.
It includes:

  • Basic and Full configurations for the Chronicle Parser resource.
  • Handwritten acceptance tests verifying full CRUD capabilities (including recreation on immutable fields and multi-step updates).
  • Native State Preservation: Utilizes ignore_read: true to handle the API's write-only validated_on_empty_logs (internal name skip_validation_on_no_logs) field, cleanly avoiding perpetual diffs and import mismatches.

This PR adds the google_chronicle_parser resource in GA.
It includes basic and full configurations, handwritten acceptance
tests for full CRUD (including recreation on immutable fields),
and a custom flattener to handle the write-only validated_on_empty_logs field.

TAG=agy
CONV=7ff89b1b-2de9-433d-a2c7-25158b871127
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 1, 2026
@github-actions github-actions Bot requested a review from melinath June 1, 2026 09:00
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/chronicle and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jun 1, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Jun 1, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7161a46:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 2383 insertions(+)
google-beta provider View Diff 4 files changed, 2383 insertions(+)
terraform-google-conversion View Diff 1 file changed, 533 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_parser (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_parser" "primary" {
  changelogs {
    entries {
      change_message = # value needed
      create_time    = # value needed
      deleted        = # value needed
      parser_version = # value needed
    }
  }
  low_code {
    field_extractors {
      append_repeated_fields = # value needed
      extractors {
        value = # value needed
      }
      preprocess_config {
        grok_regex = # value needed
        target     = # value needed
      }
    }
  }
  version_info {
    auto_upgrade_disabled = # value needed
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
42 39 1 2
Affected Service Packages
  • chronicle

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccChronicleParser_chronicleParserBasicExample
  • TestAccChronicleParser_chronicleParserFullExample_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccChronicleParser_chronicleParserBasicExample
✅ Log TestAccChronicleParser_chronicleParserFullExample_update

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@govisingh-dotcom, @melinath, @ankitgoyal0301 VCR tests complete for 7161a46!

Copy link
Copy Markdown
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that all fields are tested - see missing test report

you may also want to use samples instead of examples for tests because it allows handling update tests as well as basic tests: https://googlecloudplatform.github.io/magic-modules/reference/sample/ Migration guide: https://googlecloudplatform.github.io/magic-modules/reference/update-test-changes/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants