feat(chronicle): Add Terraform support for Chronicle Parser#17774
feat(chronicle): Add Terraform support for Chronicle Parser#17774govisingh-dotcom wants to merge 1 commit into
Conversation
This PR adds the google_chronicle_parser resource in GA. It includes basic and full configurations, handwritten acceptance tests for full CRUD (including recreation on immutable fields), and a custom flattener to handle the write-only validated_on_empty_logs field. TAG=agy CONV=7ff89b1b-2de9-433d-a2c7-25158b871127
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7161a46: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_chronicle_parser" "primary" {
changelogs {
entries {
change_message = # value needed
create_time = # value needed
deleted = # value needed
parser_version = # value needed
}
}
low_code {
field_extractors {
append_repeated_fields = # value needed
extractors {
value = # value needed
}
preprocess_config {
grok_regex = # value needed
target = # value needed
}
}
}
version_info {
auto_upgrade_disabled = # value needed
}
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @govisingh-dotcom, @melinath, @ankitgoyal0301 VCR tests complete for 7161a46! |
There was a problem hiding this comment.
Please ensure that all fields are tested - see missing test report
you may also want to use samples instead of examples for tests because it allows handling update tests as well as basic tests: https://googlecloudplatform.github.io/magic-modules/reference/sample/ Migration guide: https://googlecloudplatform.github.io/magic-modules/reference/update-test-changes/
This PR adds the
google_chronicle_parserresource in GA.It includes:
ignore_read: trueto handle the API's write-onlyvalidated_on_empty_logs(internal nameskip_validation_on_no_logs) field, cleanly avoiding perpetual diffs and import mismatches.