Iam support dataplex data product#17775
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b356a4e: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @okvidhi, @hao-nan-li VCR tests complete for b356a4e! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d4a8c57: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dataplex_data_product" "primary" {
access_approval_config {
approver_emails = # value needed
}
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @okvidhi, @hao-nan-li VCR tests complete for d4a8c57! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 06091a4: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @okvidhi, @hao-nan-li VCR tests complete for 06091a4! |
Description
This PR adds support for standard IAM resources (
iam_policy,iam_binding, andiam_member) and the optionalaccess_approval_configfield to thegoogle_dataplex_data_productresource.Key Changes
iam_policyblock toDataProduct.yamlto enable declarative permission management.nameproperty to the parent resource to provide the full resource path required for IAM identity validation.access_approval_configproperty to allow producers to define approver emails.Verification Performed