Skip to content

Iam support dataplex data product#17775

Merged
hao-nan-li merged 7 commits into
GoogleCloudPlatform:mainfrom
okvidhi:iam-support-dataplex-data-product
Jun 2, 2026
Merged

Iam support dataplex data product#17775
hao-nan-li merged 7 commits into
GoogleCloudPlatform:mainfrom
okvidhi:iam-support-dataplex-data-product

Conversation

@okvidhi
Copy link
Copy Markdown
Contributor

@okvidhi okvidhi commented Jun 1, 2026

Description

This PR adds support for standard IAM resources (iam_policy, iam_binding, and iam_member) and the optional access_approval_config field to the google_dataplex_data_product resource.

Key Changes

  • IAM Support: Added the iam_policy block to DataProduct.yaml to enable declarative permission management.
  • Field Alignment: Introduced an output-only name property to the parent resource to provide the full resource path required for IAM identity validation.
  • Approval Workflow:: Added the access_approval_config property to allow producers to define approver emails.

Verification Performed

  • Manual verification was performed in the okvidhi-testing project using provider developer overrides. Successful creation and update of the Data Product with a service account principal and approver email was verified in the Google Cloud Console.
dataplex: added IAM support for `google_dataplex_data_product` (iam_policy, iam_binding, iam_member)
dataplex: added `access_approval_config` field to `google_dataplex_data_product`

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 1, 2026
@github-actions github-actions Bot requested a review from hao-nan-li June 1, 2026 09:05
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/dataplex and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jun 1, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Jun 1, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b356a4e:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 8 files changed, 960 insertions(+)
google-beta provider View Diff 8 files changed, 960 insertions(+)
terraform-google-conversion View Diff 2 files changed, 395 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
91 87 0 4
Affected Service Packages
  • dataplex

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDataplexDataProductIamBindingGenerated
  • TestAccDataplexDataProductIamMemberGenerated
  • TestAccDataplexDataProductIamMember_basic
  • TestAccDataplexDataProductIamPolicyGenerated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccDataplexDataProductIamBindingGenerated
✅ Log TestAccDataplexDataProductIamMemberGenerated
✅ Log TestAccDataplexDataProductIamMember_basic
✅ Log TestAccDataplexDataProductIamPolicyGenerated

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@okvidhi, @hao-nan-li VCR tests complete for b356a4e!

Comment thread mmv1/products/dataplex/DataProduct.yaml
@github-actions github-actions Bot requested a review from hao-nan-li June 2, 2026 06:10
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Jun 2, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d4a8c57:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 8 files changed, 1052 insertions(+)
google-beta provider View Diff 8 files changed, 1052 insertions(+)
terraform-google-conversion View Diff 3 files changed, 427 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_data_product (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_data_product" "primary" {
  access_approval_config {
    approver_emails = # value needed
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
91 91 0 0
Affected Service Packages
  • dataplex

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@okvidhi, @hao-nan-li VCR tests complete for d4a8c57!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented Jun 2, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 06091a4:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 9 files changed, 1060 insertions(+)
google-beta provider View Diff 9 files changed, 1060 insertions(+)
terraform-google-conversion View Diff 3 files changed, 427 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
91 90 0 1
Affected Service Packages
  • dataplex

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDataplexDataProduct_dataplexDataProductFullExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccDataplexDataProduct_dataplexDataProductFullExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@okvidhi, @hao-nan-li VCR tests complete for 06091a4!

@hao-nan-li hao-nan-li added this pull request to the merge queue Jun 2, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 22c66af Jun 2, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants